[PATCH] Updated rmap VM for 2.5.23 (SMP, preempt fixes)

Craig Kulesa (ckulesa@as.arizona.edu)
Thu, 20 Jun 2002 05:08:37 -0700 (MST)


Fixed patches have been uploaded that fix significant bugs in the rmap
implementations uploaded yesterday. Please use the NEW patches (with "-2"
appended to the filename) instead. ;)

In particular, neither patch was preempt-safe; thanks go to William Irwin
for catching it. A spinlocking bug that kept SMP-builds from booting was
tripped across by Steven Cole; it affects the big rmap13b patch but not
the minimal one. That should be fixed now too. If it breaks for you, I
want to know about it! :)

Here's the changelog:

2.5.23-rmap-2: rmap on top of the 2.5.23 VM

- Make pte_chain_lock() and pte_chain_unlock()
preempt-safe (thanks to wli for pointing this out)

2.5.23-rmap13b-2: Rik's full rmap patch, applied to 2.5.23

- Make pte_chain_lock() and pte_chain_unlock()
preempt-safe (thanks to wli for pointing this out)

- Allow an SMP-enabled kernel to boot! Change bogus
spin_lock(&mapping->page_lock) invocations to either
read_lock() or write_lock(). This alters drop_behind()
in readahead.c, and reclaim_page() in vmscan.c.

- Keep page_launder_zone from blocking on recently written
data by putting clustered writeback pages back at the
beginning of the inactive dirty list. This touches
mm/page-writeback.c and fs/mpage.c. Thanks go to Andrew
Morton for clearing this issue up for me.

- Back out Andrew's read-latency2 changes at his
suggestion; it's distracting to the issue of evaluating
rmap. Thusly, we are now using the unmodified 2.5.23
IO scheduler.

FYI, these are the patches that I will benchmark in the next email.

-Craig

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/