Re: 2.5.23+ bootflag.c triggers __iounmap: bad address

Mikael Pettersson (mikpe@csd.uu.se)
Fri, 21 Jun 2002 18:44:07 +0200 (MET DST)


On Fri, 21 Jun 2002 14:43:41 +0200, Andi Kleen wrote:
>> __iounmap: bad address c4800009
>> __iounmap: bad address c4804b8c
>> __iounmap: bad address c4802009
>>
>> These warnings/errors are new since 2.5.23, which makes me
>> suspect something's wrong in the 2.5.23 iounmap changes.
>
>Does this patch fix it?
>
>
>-Andi
>
>
>
>--- linux-2.5.23-work/arch/i386/mm/ioremap.c.~2~ Tue Jun 18 02:13:09 2002
>+++ linux-2.5.23-work/arch/i386/mm/ioremap.c Fri Jun 21 14:42:23 2002
>@@ -213,9 +213,9 @@
> void iounmap(void *addr)
> {
> struct vm_struct *p;
>- if (addr < high_memory)
>+ if (addr <= high_memory)
> return;
>- p = remove_kernel_area(addr);
>+ p = remove_kernel_area(PAGE_MASK & (unsigned long) addr);
> if (!p) {
> printk("__iounmap: bad address %p\n", addr);
> return;
>

Yes, that fixed the problem on the two machines I mentioned.
Thanks.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/