Re: [PATCH] compile fix for 2.5 kdev_t compatibility macros

Steven Cole (elenstev@mesatop.com)
28 Jun 2002 09:24:18 -0600


On Fri, 2002-06-28 at 09:10, Martin Josefsson wrote:
[snip]
>
> And here's one more...
>
> --- linux-2.4.19-rc1/include/linux/kdev_t.h.orig Fri Jun 28 16:59:48 2002
> +++ linux-2.4.19-rc1/include/linux/kdev_t.h Fri Jun 28 17:01:12 2002
> @@ -82,7 +82,7 @@
> #define kdev_same(a,b) ((a) == (b))
> #define kdev_none(d) (!(d))
> #define kdev_val(d) ((unsigned int)(d))
> -#define val_to_kdev(d) ((kdev_t(d))
> +#define val_to_kdev(d) (kdev_t(d))
>
> /*
> As long as device numbers in the outside world have 16 bits only,
>
> --
> /Martin
>

Hmm. It looks like (d) should be cast to (kdev_t).
Here are both fixes (I hope).

Steven

--- linux-2.4.19-rc1/include/linux/kdev_t.h.orig Fri Jun 28 08:31:27 2002
+++ linux-2.4.19-rc1/include/linux/kdev_t.h Fri Jun 28 09:11:39 2002
@@ -81,8 +81,8 @@
#define minor(d) MINOR(d)
#define kdev_same(a,b) ((a) == (b))
#define kdev_none(d) (!(d))
-#define kdev_val(d) ((unsigned int)(d)
-#define val_to_kdev(d) ((kdev_t(d))
+#define kdev_val(d) ((unsigned int)(d))
+#define val_to_kdev(d) ((kdev_t)(d))

/*
As long as device numbers in the outside world have 16 bits only,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/