Re: [PATCH] 2.5.25 Hotplug CPU boot changes

[Rusty Russell]

In message <[e-mail]> you write
:
> On Mon, 2002-07-15 at 09:58, Rusty Russell wrote:
> > The following patches change boot sequence, and once Linus releases
> > 2.5.26, I'll be updating and sending them.  This will break every SMP
> > architecture (patch for x86 below, and I have a patch for PPC32).
> >			printk("ksoftirqd for %i failedn", hotcpu);
> 
> Q: What prevents a CPU coming up -during- an MTRR change once the rest
> of the cpu hot plugging is present ?

Nothing, that's (one of the reasons) why cpu hotplug is not
implemented on x86.

[ Disclosure: I tried to rewrite the x86 boot code to actually bring
  CPUs up one at a time, rather than the minimal wedge seen in this
  patch, and failed.  Me no x86-pert, and the boot code is hairy. ]

I'm still considering a big reader lock around the actual bringing up
of CPUs, pending me completing my audit of what code actually needs
this (surprisingly, very little generic code actually cares how many
CPUs we have, so it's mainly a few corner cases).  This would be
cheap, and allow code that cared to lock out cpu changes.

Thoughts?
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.