Re: [PATCH] orinoco_pci.c build fix

Adrian Bunk (bunk@fs.tum.de)
Tue, 16 Jul 2002 23:13:00 +0200 (CEST)


On Wed, 17 Jul 2002, Daiki Ueno wrote:

> Hi,

Hi,

> While I've tried to get drivers/net/wireless/orinoco_pci.c compiled in,
> I happened to get an error:
>
> >drivers/net/wireless/wireless_net.o(.data+0x534): undefined reference to `local symbols in discarded section .text.exit'
>
> Is there a missing __devexit_p? Here is the patch to 2.4.19-rc1.
>
> --- drivers/net/wireless/orinoco_pci.c~ Wed Jul 17 02:37:33 2002
> +++ drivers/net/wireless/orinoco_pci.c Wed Jul 17 02:38:22 2002
> @@ -364,9 +364,11 @@
> name:"orinoco_pci",
> id_table:orinoco_pci_pci_id_table,
> probe:orinoco_pci_init_one,
> - remove:orinoco_pci_remove_one,
> + remove:__devexit_p(orinoco_pci_remove_one),
> +#ifdef CONFIG_PM
> suspend:0,
> resume:0
> +#endif /* CONFIG_PM */
> };
>
> static int __init orinoco_pci_init(void)

a similar __devexit_p-patch is already in in Marcelo's BK repository (and
it will therefore be in -rc2). Why do you think the #ifdef CONFIG_PM is
needed?

> Regards,

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of time explaining its a free country because its a police state. Alan Cox

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/