Re: [PATCH] 2.5.24 : BusLogic cleanup

[Zwane Mwaikambo]

On Thu, 18 Jul 2002, Dale Amon wrote:

> On Mon, Jun 24, 2002 at 01:07:18AM -0400, Frank Davis wrote:
> > Hello all,
> >   The following patch removes some unneccessary (it seems) typedefs, and 
> > adds in the pci_set_dma_mask() check mentioned in 
> > Documentation/DMA-mapping.txt . Please review.

The driver needs more than just the dma mask set.

> Did your Buslogic patch ever get included? I'm still
> getting errors compiling 2.5.x as of .26 last night:

Probably didn't get in because the driver is still not compliant with the 
new kernel requirements for PCI/DMA

> BusLogic.c:32: #error Please convert me to Documentation/DMA-mapping.txt
> BusLogic.c: In function `BusLogic_DetectHostAdapter':
> BusLogic.c:2841: warning: long unsigned int format, BusLogic_IO_Address_T arg (arg 2)
> BusLogic.c: In function `BusLogic_QueueCommand':
> BusLogic.c:3415: structure has no member named `address'

That probably wants sg_dma_address()

> BusLogic.c: In function `BusLogic_BIOSDiskParameters':
> BusLogic.c:4141: warning: implicit declaration of function `scsi_bios_ptable'
> BusLogic.c:4141: warning: assignment makes pointer from integer without a cast
> make[2]: *** [BusLogic.o] Error 1
> 
> Given that your patch was against .24, I would guess
> it should be "relatively" safe against a .26 since it's
> only driver code that everyone else seems to be ignoring.

Well its not the friendliest code either ;)

Cheers,
	Zwane Mwaikambo

-- 
function.linuxpower.ca