Re: [PATCH] 2.5.28 small REQ_SPECIAL abstraction

James Bottomley (James.Bottomley@SteelEye.com)
Mon, 29 Jul 2002 08:44:12 -0500


axboe@suse.de said:
> Ok... I had two issues with the patch. 1) it did
> rq->flags &= REQ_QUEUED;

Yes, that was inherited from SCSI. Previously it just cleared flags and then
set REQ_BARRIER|REQ_SPECIAL. Now I needed to clear flags but preserve the
state of REQ_QUEUED, which is what that code is doing, otherwise the
blk_rq_tagged() would always fail lower down.

> I'll back down, it's not a matter of life and death after all. Here's
> the minimal patch that corrects the flag thing, and also makes
> blk_insert_request() conform to kernel style. Are we all happy?

I'm happy (as long as it works on my SCSI card).

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/