weird padding in linux/timex.h, struct timex

Muli Ben-Yehuda (mulix@actcom.co.il)
Tue, 6 Aug 2002 14:15:49 +0300


--dfmC41YZQlborXoK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,=20

struct timex in include/linux/timex.h is defined as=20

struct timex=20
{
...
int :32; int :32; int :32; int :32;
int :32; int :32; int :32; int :32;
int :32; int :32; int :32; int :32;
};=20

I assume that this is used as padding. Is there any reason for using
bitfields as padding? If there is, a comment to that effect would be
nice. If there isn't, the following patch makes the padding explicit.=20

--- 2.4.19-vanilla/include/linux/timex.h Sun Aug 4 19:16:59 2002
+++ 2.4.19-mx/include/linux/timex.h Tue Aug 6 13:49:32 2002
@@ -182,9 +182,7 @@
long errcnt; /* calibration errors (ro) */
long stbcnt; /* stability limit exceeded (ro) */
=20
- int :32; int :32; int :32; int :32;
- int :32; int :32; int :32; int :32;
- int :32; int :32; int :32; int :32;
+ char __pad[12 * 4]; /* padding */=20
};
=20
/*

--=20
I am PINK, hear me ROAR

http://vipe.technion.ac.il/~mulix/
http://syscalltrack.sf.net/

--dfmC41YZQlborXoK
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9T6/lKRs727/VN8sRAsU0AJ4sn6YEcEhMk37bhlc75uHyKHwweQCfWXXI
rGHPI3UA565u3xFVvQ9u5Rk=
=u0Ui
-----END PGP SIGNATURE-----

--dfmC41YZQlborXoK--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/