Re: [SOLVED] kernel BUG at tg3.c:1557

[Roland Kuhn]

On Wed, 7 Aug 2002, Roland Kuhn wrote:

> On Wed, 7 Aug 2002, David S. Miller wrote:
> 
> >    From: Roland Kuhn <[e-mail]>
> >    Date: Wed, 7 Aug 2002 17:36:25 +0200 (CEST)
> >    
> >    How can I help to track this down?
> > 
> > I'm stumped, sorry.
> 
> Just out of curiosity I tried it with
> 
> static void tg3_write_mailbox_reg32(struct tg3 *tp, u32 off, u32 val)
> {
>         unsigned long flags;
> 
>         spin_lock_irqsave(&tp->indirect_lock, flags);
>         writel(val, tp->regs + off);
>         spin_unlock_irqrestore(&tp->indirect_lock, flags);
> }
> 
> and that plain works. That means that only the mailbox writes have 
> additional locking around the otherwise unchanged writel() call. Does the 
> spin_lock_irqsave/spin_unlock_irqrestore take care of the PCI ordering?
> 
While loading properly, this still crashed the machine. After giving it
some thought I tried to add a dummy pci_read_config_dword() just before
the writel(), and that works! I use this function both for tr32 and
tr32_mailbox. I hammered it over one hour with a script that crashed it
always in five seconds, and not so much as a hiccup :-)

Only one question is left: can this effect be achieved more elegantly?

Ciao,
					Roland

+---------------------------+-------------------------+
|    TU Muenchen            |                         |
|    Physik-Department E18  |  Raum    3558           |
|    James-Franck-Str.      |  Telefon [phone]  |
|    85747 Garching         |                         |
+---------------------------+-------------------------+