Buglet in irq compat code in 2.5.30

Pete Zaitcev (zaitcev@redhat.com)
Wed, 7 Aug 2002 16:54:43 -0400


The save_flags used to save flags, while local_irq_save saves AND
closes interrupts, and local_irq_save_off simply does not exist.
I did not see anything on the list, perhaps nobody is bold enough
to use 2.5.30?

diff -urN -X dontdiff linux-2.5.30/include/linux/interrupt.h linux-2.5.30-sparc/include/linux/interrupt.h
--- linux-2.5.30/include/linux/interrupt.h Thu Aug 1 14:16:01 2002
+++ linux-2.5.30-sparc/include/linux/interrupt.h Wed Aug 7 13:48:25 2002
@@ -50,9 +50,9 @@
#if !CONFIG_SMP
# define cli() local_irq_disable()
# define sti() local_irq_enable()
-# define save_flags(x) local_irq_save(x)
+# define save_flags(x) local_save_flags(x)
# define restore_flags(x) local_irq_restore(x)
-# define save_and_cli(x) local_irq_save_off(x)
+# define save_and_cli(x) local_irq_save(x)
#endif


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/