Re: [PATCH] conditionally re-enable per-disk stats, convert to seq_file

[Kurt Garloff]

--sgneBHv3152wZ8jf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Christoph,

On Tue, Aug 06, 2002 at 04:08:48PM +0200, Christoph Hellwig wrote:
> This patch against 2.4.20-pre1 converts /proc/partitions to the seq_file
> interface as in 2.5, makes it report the sard-style extended disk
> statistics condititional on CONFIG_BLK_STATS and disables the gathering
> of those totally otherwise to not waste memory and processing power.
>=20
> This patch is based on the concept of Kurt's statistics patch, although
> it is implemented very differently to avoid #ifdef hell.

Actually, I was expecting criticism due to the ifdef stuff I did and was
prepared to come up with something better. But I also learned never to put
effort into something before being asked to ...

Your patch looks fine to me. Thanks for preparing it!

Regards,
--=20
Kurt Garloff                   <[e-mail]>         [Eindhoven, NL]
Physics: Plasma simulations    <[e-mail]>     [TU Eindhoven, NL]
Linux: SCSI, Security          <[e-mail]>    [SuSE Nuernberg, DE]
 (See mail header or public key servers for PGP2 and GPG public keys.)

--sgneBHv3152wZ8jf
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9UYrhxmLh6hyYd04RAvrLAKDPcmQm9MiPcOJWXMZvNuOM+ITtmACcDwUM
Gy1CaT/XQTfnfGGVtDicGEU=
=Wn25
-----END PGP SIGNATURE-----

--sgneBHv3152wZ8jf--