Re: [Lse-tech] [patch] Scalable statistics counters with /proc reporting

Ravikiran G Thirumalai (kiran@in.ibm.com)
Thu, 8 Aug 2002 10:11:45 +0530


On Wed, Aug 07, 2002 at 12:02:14PM -0700, Andrew Morton wrote:
> Christoph Hellwig wrote:
> >
> > ...
> > Also the /proc-based implementation is really ugly. It should be moved
> > over to the seq_file interface at least, a simple ramfs-style own
> > filesystem ("stats" filesystem type) would be the cleanest solution.
>
> I'd suggest that it be just a single stat counter per /proc
> file. A simple sprintf is fine for that.
>
> If it's necessary to write a new filesystem to just export a bunch
> of integers to userspace then something is seriously wrong.

Yes, that was how my previous release worked. But Rik wanted to be able
to group a bunch of counters into a single /proc file for his use.
Rik, your comments please... what do you prefer? current /proc style,
seq_file, or the earlier "one counter per /proc" style?

Thanks,
Kiran
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/