Re: [patch 1 of 2] Scalable statistics counters

[Christoph Hellwig]

On Mon, Aug 12, 2002 at 06:35:24PM +0530, Ravikiran G Thirumalai wrote:
> Hi Andrew,
> Here is the new statctr patch with some of the changes suggested by Christoph.
> Do you think the foll patch is ready to get into the mainline kernel now? 
> If so, will you forward this to Linus or shall I send the patch to him?
> The following patch works on 2.5.31. I will be mailing out the 2.5.31
> version of Dipankar's kmalloc_percpu dynamic memory allocator in a separate
> mail (since statctrs depend on them ).

But you ignored the most important suggestion.  Using proc_calc_metrics()
in new code is a mistake.  It's a sign you want to use the seq_file
interface.  And exporting it outside proc_misc.c is an even bigger mistake.