Re: [patch] PCI Cleanup

[Alan Cox]

On Tue, 2002-08-13 at 01:08, Matthew Dobson wrote:

> -	if (!value) 
> -		return -EINVAL;
> -
> -	result = pci_conf1_read(0, dev->bus->number, PCI_SLOT(dev->devfn), 
> -		PCI_FUNC(dev->devfn), where, 2, &data);
> -

This stil has the same problems as it did last time you posted it. The
pointless NULL check and the increased complexity over duplicating about
60 lines of code and having pci_conf1 ops cleanly as we do in 2.4.

The !value check is extremely bad because it turns a critical debuggable
software error into a silent unnoticed mistake.

Fixing the code instead of just resending it might improve the changes
of it being merged no end.

Alan