Re: [PATCH] cdrom sane fallback vs 2.4.20-pre1

James Bottomley (James.Bottomley@SteelEye.com)
Tue, 13 Aug 2002 09:13:39 -0500


> > - if (ret) {
> > + if (ret && sense.sense_key==0x05 && sense.asc==0x20 && sense.ascq==0x00) {
>
> Do you really need to hardcode this values ?

We have no #defines for the asc and ascq codes (they are interpreted in
constants.c but the values are hardcoded in there too). There is a #define
for sense_key 0x05 as ILLEGAL_REQUEST in scsi/scsi.h, but these #defines have
annoyed a lot of people by being rather namespace polluting.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/