Re: [patch] user-vm-unlock-2.5.31-A2

Jamie Lokier (lk@tantalophile.demon.co.uk)
Fri, 16 Aug 2002 00:29:29 +0100


Jamie Lokier wrote:
> It's probably most simple to use two consecutive words, for simplicity
> and to avoid needing an atomic store (which is slower on some
> architectures).

Ignore the above bit, I missed that you are already using two
independent addresses (in edx and edi), so atomicity is not an issue.
It might be cleaner to use a single address pointing to two consecutive
words anyway (for CLONE_SETTID and CLONE_VM_RELEASE) just to save a
register for future use - register pressure around clone() being a
precious thing, occasionally.

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/