Re: [BK PATCH] devfs cleanups for 2.5.29

Roman Zippel (zippel@linux-m68k.org)
Mon, 19 Aug 2002 11:37:43 +0200 (CEST)


Hi,

On Sun, 18 Aug 2002, Richard Gooch wrote:

> > > > In the "devfs=only" case, where is the module count incremented, when a
> > > > block device is opened?
>
> I've already told you about fops_get(). And for a block device, it's
> def_blk_fops.open().

Which basically calls block_dev.c:do_open() and the module count there is
only incremented if get_blkfops() is successfull, which is a dummy in this
case. So where again is the module count incremented?

> I've fixed that in my tree,
> by using devfs_get_ops(), which safely handles this. I've also added
> some comments, to make it clearer.

You never answered my question, why you insist on managing the ops
pointer. The far easier fix would be to simply remove this nonsense.

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/