Re: [PATCH] rmap bugfix, try_to_unmap
Rik van Riel (riel@conectiva.com.br)
Mon, 19 Aug 2002 17:15:42 -0300 (BRT)
On Mon, 19 Aug 2002, Daniel Phillips wrote:
> On Monday 12 August 2002 16:58, Rik van Riel wrote:
> > case SWAP_FAIL:
> > ret = SWAP_FAIL;
> > - break;
> > + goto give_up;
>
> Yes, I looked at that many times while reading the break as a 'break
> from loop' every time. Using the same keyword to mean 'stop looping'
> and 'endcase' was, by any measure, a stupid idea.
What's even more curious is that 'continue' has the exact
same effect on 'switch' ...
regards,
Rik
--
Bravely reimplemented by the knights who say "NIH".
http://www.surriel.com/ http://distro.conectiva.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/