Re: [PATCH] lock assertion macros for 2.5.31

Jesse Barnes (jbarnes@sgi.com)
Wed, 21 Aug 2002 11:46:33 -0700


On Wed, Aug 21, 2002 at 11:40:10AM -0700, Andrew Morton wrote:
> Well I added checks just to kmalloc, kmem_cache_alloc, __alloc_pages
> and saw a shower of bloopers during bootup. Such as drivers/ide/probe.c:init_irq()
> calling request_irq() inside ide_lock.

Wow. Sounds like some good code to have around.

> > Anyway, here's an updated version of the lock assertion patch.
>
> Well I like it. It's unintrusive, imparts useful info to the reader
> and checks stuff at runtime.

Great!

> These things are self-evident and even self-checking. They don't need
> supporting documentation. I'll put out a test tree RSN, include this
> in it.

Excellent. Thanks a lot for your feedback.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/