Re: [BUG/PATCH] : bug in tty_default_put_char()

[Jean Tourrilhes]

On Mon, Aug 26, 2002 at 07:57:04PM +0100, Alan Cox wrote:
> On Mon, 2002-08-26 at 19:07, Jean Tourrilhes wrote:
> > 	Hi,
> > 
> > 	Bug : tty_default_put_char() doesn't check the return value of
> > tty->driver.write(). However, the later may fail if buffers are full.
> > 
> > 	Solution : It's not obvious what should be done. The attached
> > patch is certainly wrong, but gives you an idea of what the problem
> > is.
> 
> Make it an int and return the tty->driver.write value. We know that
> since its void nobody is currently checking the error code, and now they
> can where it matters

	Just check drivers/char/n_tty.c for every occurence of
put_char() and be scared. The problem is to find a practical solution.
	For myself, I've added some clever workaround in IrCOMM to
accept data before full setup.

	Regards,

	Jean