Re: [PATCH] make raid5 checksums preempt-safe

Thunder from the hill (thunder@lightweight.ods.org)
Mon, 26 Aug 2002 15:09:43 -0600 (MDT)


Hi,

On 26 Aug 2002, Robert Love wrote:
> @@ -543,6 +545,7 @@
> #define XMMS_SAVE \
> + preempt_disable(); \
> __asm__ __volatile__ ( \
> "movl %%cr0,%0 ;\n\t" \
> "clts ;\n\t" \
> @@ -564,7 +567,8 @@
> "movl %0,%%cr0 ;\n\t" \
> : \
> : "r" (cr0), "r" (xmm_save) \
> - : "memory")
> + : "memory") \
> + preempt_enable();
> @@ -38,7 +38,8 @@
> #define XMMS_SAVE \
> - asm volatile ( \
> + preempt_disable(); \
> + asm volatile ( \
> "movq %%cr0,%0 ;\n\t" \
> "clts ;\n\t" \
> "movups %%xmm0,(%1) ;\n\t" \
> @@ -59,7 +60,8 @@
> "movq %0,%%cr0 ;\n\t" \
> : \
> : "r" (cr0), "r" (xmm_save) \
> - : "memory")
> + : "memory") \
> + preempt_enable();

These will suck when on if, I guess... Anyway, will this compile at all?
There seems no semicolon after the asm volatile ()

Thunder

-- 
--./../...-/. -.--/---/..-/.-./..././.-../..-. .---/..-/.../- .-
--/../-./..-/-/./--..-- ../.----./.-../.-.. --./../...-/. -.--/---/..-
.- -/---/--/---/.-./.-./---/.--/.-.-.-
--./.-/-.../.-./.././.-../.-.-.-

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/