Re: Loop devices under NTFS

[Adam J. Richter]

>On Tue, Aug 27, 2002 at 05:40:52AM -0700, Adam J. Richter wrote:
>> 	There are only a few file systems that provide writable files
>> without aops->{prepare,commit}_write.  I think they are just tmpfs,
>> ntfs and intermezzo.  If all file systems that provided writable files
>> could be expected to provide {prepare,commit}_write, I could eliminate
>> the file_ops->{read,write} code from loop.c.

>This is the wrong level of abstraction.  There is no reason why a filesystem
>has to use the pagecache at all.

	Are you complaining about something in loop.c, or are you just
saying that you'd like to see some kind of
generic_file_{prepare,commit}_write routines that plain files in all
writable filesystems could use?

>Note that there is a more severe bug in loop.c:  it's abuse of
>do_generic_file_read.  

	Could you please elaborate on this and give an example where
it return incorrect data, deadlock, generate a kernel oops, etc.?

Adam J. Richter     __     ______________   575 Oroville Road
[e-mail]     \ /                  Milpitas, California 95035
[phone]         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."