Re: [PATCH] XFree v4.2.x DRM/DRI Support for 2.4.20-pre4

[Willy Tarreau]

On Tue, Aug 27, 2002 at 10:27:40PM +0100, Christoph Hellwig wrote:
> On Tue, Aug 27, 2002 at 10:54:50PM +0200, Marc-Christian Petersen wrote:
> > Hi there,
> > 
> > this adds DRM/DRI Support for recent versions of XFree, f.e. v4.2.0 with a 
> > slight modification. If you select SiS DRM Module, you also have to select 
> > FrameBuffer SiS support otherwise it will result in unresolved symbols or 
> > linking failure.
> 
> Don't do this.   Alan already has a sane version in his tree which I've made
> ready for and sent to Marcelo.  It wouldn't hurt if you read lkml..
> 
> The patch you posted is the crap directly from the XFfree repo and backs out
> kernel changes.  It might be enough for a random collection of junk patches
> but certainly does not meet the quality criteria for official kernels.

Christoph,

why do you always feel the need to discourage people who offer their
contribution ? Your two first sentences are quite enough to let Marc-Christian
understand that his patch isn't as good as YOURS. The rest of the mail is pure
gratuitous insults, just like every other mail you send these times (except
those in which you compliment yourself). Since a few weeks, each time I see
a mail from you, before opening it, I ask to myself "well, who is he killing
today ?".

Perhaps you're fed up with crap in the kernel, but IMHO that's not this way
that you'll get rid of it. This list is a developper's list, so it tends to
be constructive by nature. So please be a little more tolerant with other
people, particularly when they are contributing.

Thanks for your attention,
Willy