Re: Large block device patch, part 1 of 9

[Benjamin LaHaise]

On Tue, Aug 27, 2002 at 03:23:04PM +0000, Pavel Machek wrote:
> Hi!
> 
> > Then the following works properly without ugly casts or warnings:
> > 
> > 	__u64 val = 1;
> > 
> > 	printk("at least "PFU64" of your u64s are belong to us\n", val);
> 
> Casts are ugly but this looks even worse. I'd go for casts.

Casts override the few type checking abilities the compiler gives us.  At 
least with the PFU64 style, we'll get warnings when someone changes a variable 
into a pointer without remembering to update the printk.

		-ben
-- 
"You will be reincarnated as a toad; and you will be much happier."