Re: Bug in kernel code?

Luca Barbieri (ldb@ldb.ods.org)
28 Aug 2002 06:29:59 +0200


--=-nGlGpXBkAVm32AMDa3DW
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Wed, 2002-08-28 at 06:07, David S. Miller wrote:
> From: Luca Barbieri <ldb@ldb.ods.org>
> Date: 28 Aug 2002 06:10:39 +0200
>
> I'm not saying that it's serious bug, just that using __ffs is more
> appropriate than reimplementing it incorrectly and inefficiently.
>
> ffs won't find the smallest power of 2 >= some_arbitrary_value.
> That is what this code is doing.
Yes you are right, fls should be used there, not ffs.

--=-nGlGpXBkAVm32AMDa3DW
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQA9bFHGdjkty3ft5+cRApWnAJ90gL7kXMunuES3NtxDYYm8+D1zrACdFY2W
o1K/Hk9X7YUnQt0EsUpPeNM=
=CWDn
-----END PGP SIGNATURE-----

--=-nGlGpXBkAVm32AMDa3DW--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/