Re: Compiling 2.5.32

[Adrian Bunk]

On Thu, 29 Aug 2002, Dave Hansen wrote:

> Michael Obster wrote:
> > can anybody give me hint. I don't think it is a bug, but i don't know
> > what this error means for me. It is in "make bzImage" and the config is
> > attached. Symlink asm is on asm-i386 and i added "ln -s
> > /usr/src/linux/include/asm-generic /usr/include/asm-generic". Build
> > environment is Athlon, Kernel 2.4.18, gcc 2.95.3
> > <snip>
> > drivers/built-in.o(.data+0x2fab4): undefined reference to `local symbols
>
>  From what I understand this happens when these conditions are met:
> 1. You use a recent version of binutils (Debian has one)
> 2. CONFIG_HOTPLUG is not set
> 3. You compile a driver that doesn't properly use __devexit_p macro
>
> I fixed this in the IPS driver:
> haveblue/cset@1.485.7.2">http://linus.bkbits.net:8080/linux-2.5/user=haveblue/cset@1.485.7.2
>
> So, find and fix the driver, use hotplug, or get an older binutils.

Michael's problem is drivers/net/tulip/de2104x.c and this problem is known
since several months.

There are two possible solutions:

1. make the driver hot-pluggable
2. #ifdef the .remove away

Jeff Garzik doesn't want 1. until "someone actually tells me they are
trying to hot-plug such a card" and he didn't apply the following patch to
#ifdef the .remove away if the driver is compiled statically into the
kernel:

--- drivers/net/tulip/de2104x.c.old	2002-08-30 01:06:09.000000000 +0200
+++ drivers/net/tulip/de2104x.c	2002-08-30 01:06:45.000000000 +0200
@@ -2216,7 +2216,9 @@
 	.name		= DRV_NAME,
 	.id_table	= de_pci_tbl,
 	.probe		= de_init_one,
+#ifdef MODULE
 	.remove		= de_remove_one,
+#endif
 #ifdef CONFIG_PM
 	.suspend	= de_suspend,
 	.resume		= de_resume,

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox