Re: Compiling 2.5.32

[Jeff Garzik]

Adrian Bunk wrote:
> Jeff Garzik doesn't want 1. until "someone actually tells me they are
> trying to hot-plug such a card" and he didn't apply the following patch to
> #ifdef the .remove away if the driver is compiled statically into the
> kernel:
> 
> 
> --- drivers/net/tulip/de2104x.c.old	2002-08-30 01:06:09.000000000 +0200
> +++ drivers/net/tulip/de2104x.c	2002-08-30 01:06:45.000000000 +0200
> @@ -2216,7 +2216,9 @@
>  	.name		= DRV_NAME,
>  	.id_table	= de_pci_tbl,
>  	.probe		= de_init_one,
> +#ifdef MODULE
>  	.remove		= de_remove_one,
> +#endif
>  #ifdef CONFIG_PM
>  	.suspend	= de_suspend,
>  	.resume		= de_resume,

You missed my recent message, I think.

Currently in 2.5.x, you should be able to replace that #ifdef with 
__devexit_p -- without changing the de_remove_one prototype.  I updated 
the definition of __devexit_p in 2.5.30 or so.

	Jeff