Re: Large block device patch, part 1 of 9

[Daniel Phillips]

On Tuesday 03 September 2002 22:04, Benjamin LaHaise wrote:
> On Tue, Sep 03, 2002 at 10:02:38PM +0200, Daniel Phillips wrote:
> > If you must have a clever macro:
> > 
> >    #define lli(foo) (long long int) (foo)
> >    #define llu(foo) (long long unsigned) (foo)
> > 
> > The %lli/%llu have to be there in the format string (modulo as-yet-uninvented
> > printk hackery) so the cast might as well be there as well.
> 
> Do you not read the messages in a thread before posting?
> 
> 	static inline long long llsect(sector_t sect) { return sect; }
> 
> was the suggestion.

I didn't like it, I thought it was awkward.  This is better:

   printk("%lli ", llu(sect));

and

   printk("%lli ", (long long unsigned) sect);

is probably better yet.  Why get fancy.

-- 
Daniel