Re: can we drop early_serial_setup()?

Matt Porter (porter@cox.net)
Sat, 21 Sep 2002 06:45:04 -0700

On Fri, Sep 20, 2002 at 04:23:27PM -0700, David Mosberger wrote:
> >>>>> On Fri, 20 Sep 2002 16:33:57 -0700, Matt Porter <porter@cox.net> said:
>
> Matt> serial8250_ports and serial8250_pops are not static structs
> Matt> in your tree?
>
> It is. The new routine (early_register_port) goes into 8250.c, so that's
> fine.

That will be fine then. I misconstrued your first statements as
indicating that we should duplicate this code in each arch (which
I didn't like). As far as PPC is concerned, go ahead and wipe
out early_serial_setup when you bring in early_register_port.

FWIW, there's actually been more PPC platforms than ev64260 using
early_serial_setup. They had abandoned it temporarily for a less
flexible approach due to the breakage.

Thanks,

-- 
Matt Porter
porter@cox.net
This is Linux Country. On a quiet night, you can hear Windows reboot.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/