Re: [Lse-tech] [PATCH 1/2] node affine NUMA scheduler

Martin J. Bligh (mbligh@aracnet.com)
Sun, 22 Sep 2002 12:24:42 -0700


>> + int this_pool = CPU_TO_NODE(this_cpu);
>> + int this_pool=CPU_TO_NODE(this_cpu), weight, maxweight=0;
>
> Howcome you can use the CPU_TO_NODE abstraction here ...
>
>> + /* build translation table for CPU_TO_NODE macro */
>> + for (i = 0; i < NR_CPUS; i++)
>> + if (cpu_online(i))
>> + lnode_number[i] = pnode_to_lnode[SAPICID_TO_PNODE(cpu_physical_id(i))];
>
> But not here?

Doh! Because you're building the list to use for CPU_TO_NODE,
obviously ;-) Sorry.

Should still get buried back down into the arch code though.

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/