Re: [patch] exit-fix-2.5.38-E3

Daniel Jacobowitz (dan@debian.org)
Wed, 25 Sep 2002 16:13:38 -0400


On Wed, Sep 25, 2002 at 09:20:01PM +0200, Ingo Molnar wrote:
> @@ -57,31 +58,31 @@
> void release_task(struct task_struct * p)
> {
> struct dentry *proc_dentry;
> + task_t *leader;
>
> - if (p->state != TASK_ZOMBIE)
> + if (p->state < TASK_ZOMBIE)

Could you check TASK_ZOMBIE and TASK_DEAD explicitly, or add a comment
in sched.h saying that only DEAD should be above ZOMBIE? Otherwise, if
someone needs a new task state, this'll get out of sync.

Just my 2c.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/