[PATCH] 2.5.44 and Secondary Channel Only configuration Kernel Ooops

Jason Williams (jason_williams@suth.com)
21 Oct 2002 09:13:01 -0400


--=-4cM6w68X8PyLS3KMPaRE
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Here is a patch to correct the problem with the IDE code when you have
the Secondary Channel Only enabled in your BIOS. If you have only the
secondary channel enabled, a null pointer get passed to the
ide_iomio_dma function as the part of the hwif var (more specifically
hwif->mate) This patch puts in some extra sanity checks in that section
so make sure we don't hit the null.

Jason

P.S. This is a continuation of a previous patch I submitted for 2.5.43
which wasn't committed and I didn't send that to the maintainer (Sorry
Andre) so I am resending it now as a patch to the 2.5.44 kernel.

--=-4cM6w68X8PyLS3KMPaRE
Content-Description:
Content-Disposition: inline; filename=ide-sec-channel-fix.patch
Content-Transfer-Encoding: quoted-printable
Content-Type: text/x-patch; charset=ISO-8859-1

diff -u -r linux-2.5.44-vanilla/drivers/ide/ide-dma.c linux-2.5.44/drivers/=
ide/ide-dma.c
--- linux-2.5.44-vanilla/drivers/ide/ide-dma.c 2002-10-21 08:02:49.00000000=
0 -0500
+++ linux-2.5.44/drivers/ide/ide-dma.c 2002-10-21 08:56:49.000000000 -0500
@@ -905,7 +905,12 @@
request_region(base+16, hwif->cds->extra, hwif->cds->name);
hwif->dma_extra =3D hwif->cds->extra;
}
- hwif->dma_master =3D (hwif->channel) ? hwif->mate->dma_base : base;
+ if(!hwif->mate && hwif->channel){
+ hwif->dma_master=3Dbase;
+ }
+ else{
+ hwif->dma_master =3D (hwif->channel) ? hwif->mate->dma_base : base;
+ }
if (hwif->dma_base2) {
if (!check_mem_region(hwif->dma_base2, ports))
request_mem_region(hwif->dma_base2, ports, hwif->name);
@@ -925,8 +930,13 @@
if ((hwif->cds->extra) && (hwif->channel =3D=3D 0)) {
request_region(base+16, hwif->cds->extra, hwif->cds->name);
hwif->dma_extra =3D hwif->cds->extra;
+ }=09
+ if(!hwif->mate && hwif->channel){
+ hwif->dma_master=3Dbase;
+ }
+ else{
+ hwif->dma_master =3D (hwif->channel) ? hwif->mate->dma_base : base;
}
- hwif->dma_master =3D (hwif->channel) ? hwif->mate->dma_base : base;
if (hwif->dma_base2) {
if (!request_region(hwif->dma_base2, ports, hwif->name))
{

--=-4cM6w68X8PyLS3KMPaRE--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/