RE: [PATCH] 2.5.44-ac3, cciss, more scatter gather elements

[Cameron, Steve]

Jens Axboe wrote:
> On Fri, Oct 25 2002, Stephen Cameron wrote:
> > 
> > Add blk_rq_map_sg_one_by_one function to ll_rw_blk.c in order to allow a low 
> > level driver to map scatter gather elements from the block subsystem one 
> > at a time 
[...]
> I have to say that I think this patch is ugly, and a complete 
> duplicate of existing code. This is always bad, especially in the case of
> something not really straight forward (like blk_rq_map_sg()). A hack.

Yes, I sort of figured you'd say that.  I was just trying to get the 
ball rolling.

> 
> I can understand the need for something like this, for drivers that
> can't use a struct scatterlist directly. I'd rather do this in a
> different way, though.
[...]

Ok, I will (try to) rewrite it as you suggest.
  
> Oh, and do try to follow the style. It's
[...]

Well, it doesn't look like cpqfc, at least.
Heh, I count it as a victory that you choose such small things
to complain about.  Thanks for your time reviewing this.

-- steve