Re: [PATCH]: linux-2.5.44uc1 (MMU-less support)

[Greg Ungerer]

Hi Sam,

Sam Ravnborg wrote:
> On Sun, Oct 27, 2002 at 02:19:38AM +1000, Greg Ungerer wrote:
> 
>>   - arch Makefiles rewritten
> 
> Took a look at them.
> See comments below.

Thanks.
Rolled on these in to the next patch set.

Had to make one small adjustment:

> +
> +arch/$(ARCH)/kernel/asm-offsets.s: include/asm include/linux/version.h \
> +				   include/config/MARKER
> +
> +include/asm-$(ARCH)/asm-offsets.h.tmp: arch/$(ARCH)/kernel/asm-offsets.s
> +	@$(generate-asm-offsets.h) < $< > $@
> +
> +include/asm-$(ARCH)/asm-offsets.h: include/asm-$(ARCH)/asm-offsets.h.tmp
> +	@echo -n '  Generating $@'
> +	@$(update-if-changed)
> Combine it like this instead:
> include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \
> 				   include/asm include/linux/version.h \
> 				   include/config/MARKER
> 	@echo -n '  Generating $@'
> 	@$(generate-asm-offsets.h) < $< > $@
                                           ^^^

This needs to be $@.tmp, "update-if-changed" specifically looks
for the .tmp named file.

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Wizard        EMAIL:  [e-mail]
Snapgear Pty Ltd                               PHONE:    [phone]
825 Stanley St,                                  FAX:    [phone]
Woolloongabba, QLD, 4102, Australia              WEB:   www.SnapGear.com