Re: [BK][PATCH] Reiser4, will double Linux FS performance, pleaseapply

Tomas Szepe (szepe@pinerecords.com)
Sat, 2 Nov 2002 14:24:21 +0100


> This should help:
>
> diff -Nru a/txnmgr.c b/txnmgr.c
> --- a/txnmgr.c Wed Oct 30 18:58:09 2002
> +++ b/txnmgr.c Fri Nov 1 20:13:27 2002
> @@ -1917,7 +1917,7 @@
> return;
> }
>
> - if (!jnode_is_unformatted) {
> + if (jnode_is_znode(node)) {
> if ( /**jnode_get_block(node) &&*/
> !blocknr_is_fake(jnode_get_block(node))) {
> /* jnode has assigned real disk block. Put it into

Jup, this fixes the leak, but free space still isn't reported accurately
until after sync gets called, which I believe is a bug too.

Compare:
[reiser3]
$ pwd
/tmp
$ dd if=/dev/zero of=testfile bs=16k count=64
64+0 records in
64+0 records out
$ df /
Filesystem 1k-blocks Used Available Use% Mounted on
/dev/sda1 526296 330696 195600 63% /
$ rm testfile
$ df /
Filesystem 1k-blocks Used Available Use% Mounted on
/dev/sda1 526296 329672 196624 63% /
$ sync
$ df /
Filesystem 1k-blocks Used Available Use% Mounted on
/dev/sda1 526296 329672 196624 63% /

[reiser4]
$ pwd
/ap/tmp
$ dd if=/dev/zero of=testfile bs=16k count=64
64+0 records in
64+0 records out
$ df /ap
Filesystem 1k-blocks Used Available Use% Mounted on
/dev/sda2 1490332 1152 1489180 1% /ap
$ rm testfile
$ df /ap
Filesystem 1k-blocks Used Available Use% Mounted on
/dev/sda2 1490332 1160 1489172 1% /ap
$ sync
$ df /ap
Filesystem 1k-blocks Used Available Use% Mounted on
/dev/sda2 1490332 128 1490204 1% /ap

T.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/