Re: Patch: 2.5.45 PCI Fixups for PCI HotPlug

Greg KH (greg@kroah.com)
Sat, 2 Nov 2002 23:58:06 -0800


On Sat, Nov 02, 2002 at 04:56:58PM -0800, Lee, Jung-Ik wrote:
> Hi Greg,
>
> The following patch changes function scopes only but fixes kernel dump on
> Hot-Add of PCI bridge cards.

Applied, thanks.

Hm, in looking at this, I know the majority of people who want
CONFIG_HOTPLUG probably do not run with CONFIG_PCI_HOTPLUG as the
hardware's still quite rare. To force those people to keep around all
of the PCI quirks functions and tables after init happens, is a bit
cruel. I wonder if it's time to start having different subsystems
modify __devinit depending on their config variables.

Does this sound like a good idea? If so, I can probably knock up
something for the PCI code pretty easily (yes, I'll keep in mind CardBus
stuff, not all hotplug pci is on servers...)

__pci_devinit anyone? :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/