Re: [BK][PATCH] Reiser4, will double Linux FS performance, pleaseapply

[Nikita Danilov]

Tomas Szepe writes:
 > >  > Hi,
 > >  > 
 > >  > Another one: trying to build 2.5.45 off a reiser4 mountpoint, I get:
 > >  > 
 > >  > reiser4[pdflush(7)]: flush_scan_extent (fs/reiser4/flush.c:3127)[nikita-2732]:
 > >  > WARNING: Flush raced against extent->tail
 > >  > reiser4[pdflush(7)]: jnode_flush (fs/reiser4/flush.c:1024)[jmacd-16739]:
 > >  > WARNING: flush failed: -11
 > >  > jnode_flush failed with err = -11
 > > 
 > > Can you please try the following patch to the fs/reiser4/flush.c:
 > > ----------------------------------------------------------------------
 > > --- /tmp/flush.c	Mon Nov  4 14:32:21 2002
 > > +++ flush.c	Mon Nov  4 14:32:32 2002
 > > @@ -3149,7 +3149,8 @@ flush_scan_extent(flush_scan * scan, int
 > >  				   only. Will be removed. */
 > >  				warning("nikita-2732", 
 > >  					"Flush raced against extent->tail");
 > > -				ret = -EAGAIN;
 > > +				scan->stop = 1;
 > > +				ret = 0;
 > >  				goto exit;
 > >  			}
 > >  			assert("jmacd-1230", item_is_extent(&scan->parent_coord));
 > 
 > Seems to fix the flush errors, however, I can still see the race warnings.

Good. Warning was left there for debugging. I shall remove it.

 > Worse though, at one point I stumbled upon the following:
 > 
 > $ df /ap
 > Filesystem           1k-blocks      Used Available Use% Mounted on
 > /dev/sda2              1490332 -73786976294838198272   1498808 101% /ap
 > 
 > This was right after I hit the reset button while compiling the kernel
 > off a reiser4 mountpoint, went on to finish the build after reboot and
 > then "rm -rf"'d the whole source tree (i.e. there was nothing on the
 > filesystem again).
 > 
 > reiser4.o is 20021031 plus the rmdir leak fix from this thread plus
 > your patch above.

Do you have debugging on?

 > 
 > >  > ... after which r4 crashes completely --
 > >  > Starts to hog all cpu time and umount() never goes through.
 > > 
 > > Try to wait a bit more and check whether any more "WARNING: Too many
 > > iterations" appear, OK?
 > 
 > Jup, now all I get is the race warnings.
 > 
 > -- 
 > tomas szepe <[e-mail]>

Nikita.