Re: [PATCH] Module loader against 2.5.46: 9/9

[Keith Owens]

On Tue, 05 Nov 2002 11:47:27 +1100, 
Rusty Russell <[e-mail]> wrote:
>Since I believe kallsyms is important, this reimplements it sanely,
>using the current module infrastructure, and not using an external
>kallsyms script.
>
>FYI, the previous interface was:
>
>int kallsyms_symbol_to_address(
>	const char       *name,			/* Name to lookup */
>	unsigned long    *token,		/* Which module to start with */
>	const char      **mod_name,		/* Set to module name or "kernel" */
>	unsigned long    *mod_start,		/* Set to start address of module */
>	unsigned long    *mod_end,		/* Set to end address of module */
>	const char      **sec_name,		/* Set to section name */
>	unsigned long    *sec_start,		/* Set to start address of section */
>	unsigned long    *sec_end,		/* Set to end address of section */
>	const char      **sym_name,		/* Set to full symbol name */
>	unsigned long    *sym_start,		/* Set to start address of symbol */
>	unsigned long    *sym_end		/* Set to end address of symbol */
>	);
>
>The new one is:
>/* Lookup an address.  modname is set to NULL if it's in the kernel. */
>const char *kallsyms_lookup(unsigned long addr,
>			    unsigned long *symbolsize,
>			    unsigned long *offset,
>			    char **modname);

If you are going to change the interface then don't call it kallsyms.
kallsyms and that interface were designed to kernel debugging in
general and kdb in particular.  I need all the fields for decent
debugging and I refuse to allow my kallsyms code to be appropiated for
somebody else's usage if it stops kdb from working!