Re: [PATCH] remove extern inline from quotaops.h

Christoph Hellwig (hch@infradead.org)
Wed, 6 Nov 2002 18:43:48 +0000


On Wed, Nov 06, 2002 at 10:27:22AM -0800, Andrew Morton wrote:
> Denis Vlasenko wrote:
> >
> > For example,
> >
> > static __inline__ int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> > {
> > lock_kernel();
> > if (sb_any_quota_enabled(inode->i_sb)) {
>
> That's nuts.
>
> Here you go. Saves 7k in an ext2+ext3 build, and a lot of it is
> fastpath. This will significantly reduce the cache footprint
> which the kernel presents to applications which are performing
> filesystem operations.

What about giving it non-shouting names while you're at it?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/