Re: [PATCH] 2.5.46: epoll ep_insert doesn't wake waiters if events

Davide Libenzi (davidel@xmailserver.org)
Thu, 7 Nov 2002 15:24:36 -0800 (PST)


On Thu, 7 Nov 2002, Jay Vosburgh wrote:

>
> The logic in fs/eventpoll.c:ep_insert() checks to see if events are
> already present when processing an EP_CTL_ADD operation, and, if any are,
> adds them to the list. It does not wake up any waiters, so, e.g., another
> thread waiting in epoll_wait() will not be awakened for these events. The
> fix is to have ep_insert() do wakeups, just as ep_poll_callback() does when
> it adds events.

Matthew Kirk already made me notice this yesterday and it's in my code ( 0.37 ).
I was ashame to make another post to Linus :) so I delayed the post.
Linus, I have a few bits. Let me know if you want them now or we will
delay to 2.5.47 ...

- Davide

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/