[PATCH] 2.5.46: sysfs broken for partitions

Rick Lindsley (ricklind@us.ibm.com)
Thu, 07 Nov 2002 17:53:25 -0800


An ignored return value can cause a whole subset of the sysfs tree to go
silent. "cat /sys/block/sda/sda1/*" yields nothing without the patch, and
mysterious but appropriate numbers with it.

Rick

diff -ru linux-2.5.46/fs/partitions/check.c stat-2.5.46-rl1/fs/partitions/check.c
--- linux-2.5.46/fs/partitions/check.c Mon Nov 4 14:30:50 2002
+++ stat-2.5.46-rl1/fs/partitions/check.c Thu Nov 7 16:31:34 2002
@@ -294,7 +294,7 @@
struct part_attribute * part_attr = container_of(attr,struct part_attribute,attr);
ssize_t ret = 0;
if (part_attr->show)
- part_attr->show(p,page,count,off);
+ ret = part_attr->show(p,page,count,off);
return ret;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/