> Hi,
> In the tulip driver, the .remove entry of struct pci_driveris
> declared __devexit_p but the function is declared __exit. This
> causes a relocation error when building as a built-in (not a module),
> when CONFIG_HOTPLUG is defined.
Yes... alan snuck that __devexit_p usage in there ;-)
We need to create __exit_p as the #warning indicates, because this
driver does not support CONFIG_HOTPLUG intentionally. For now, I think
it is better to add #ifdef MODULE to the driver in struct pci_driver
definition, because using "__devexit" as in your patch is incorrect.
So if you wanted to submit the patch changing __devexit_p to #ifdef
MODULE, that could probably be applied...
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/