Re: [PATCH] More missing includes [1/4]

Russell King (rmk@arm.linux.org.uk)
Mon, 18 Nov 2002 23:17:45 +0000

On Mon, Nov 18, 2002 at 11:16:04PM +0100, Geert Uytterhoeven wrote:
>
> Add missing #include <linux/init.h>
>
> --- linux-2.5.48/drivers/scsi/scsi.h Mon Nov 18 10:03:40 2002
> +++ linux-m68k-2.5.48/drivers/scsi/scsi.h Mon Nov 18 14:18:21 2002
> @@ -18,6 +18,7 @@
> #include <linux/config.h> /* for CONFIG_SCSI_LOGGING */
> #include <linux/devfs_fs_kernel.h>
> #include <linux/proc_fs.h>
> +#include <linux/init.h>
>
> /*
> * Some of the public constants are being moved to this file.
>

The more obvious solution is to remove the __initdata from the
declaration on line 545. Such usage of __initdata (and __init)
serves no purpose.

--- orig/drivers/scsi/scsi.h Mon Nov 18 09:52:15 2002
+++ linux/drivers/scsi/scsi.h Mon Nov 18 15:25:42 2002
@@ -542,7 +542,7 @@
unsigned flags;
};

-extern struct dev_info scsi_static_device_list[] __initdata;
+extern struct dev_info scsi_static_device_list[];

/*
* scsi_dev_info_list: structure to hold black/white listed devices.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/