Re: [CHECKER] 74 potential buffer overruns in 2.5.33

[Jens Axboe]

On Tue, Nov 19 2002, Andy Chou wrote:
> Here are 74 out-of-bounds array accesses in Linux 2.5.33 found by the

Ewwww, why so old??

> [BUG] Seems bad.
> /home/acc/linux/2.5.33/drivers/block/ll_rw_blk.c:556:blk_dump_rq_flags: 
> ERROR:BUFFER:556:556:Array bounds error: rq_flags[12] indexed with [12]
> 
> 	printk("%s: dev %02x:%02x: ", msg, major(rq->rq_dev), 
> minor(rq->rq_dev));
> 	bit = 0;
> 	do {
> 		if (rq->flags & (1 << bit))
> 
> Error --->
> 			printk("%s ", rq_flags[bit]);
> 		bit++;
> 	} while (bit < __REQ_NR_BITS);

This was due to someone adding and removing __REQ_* flags and not
changing blk_dump_rq_flags(). 2.5.48 has no such bug anymore, I fixed
this up long ago.

-- 
Jens Axboe