Re: [PATCH] Allow others to use ACPI EC interface

Stelian Pop (stelian.pop@fr.alcove.com)
Fri, 22 Nov 2002 00:31:19 +0100


On Wed, Nov 20, 2002 at 08:00:13PM -0800, Andy Grover wrote:

> Hi Stelian,

Hi. Sorry for replying so late.

> Do you have a system that works with ACPI?

Yes, My C1VE Vaio works well with the latest ACPI.

> This patch against 2.5.latest adds externally callable ec_read and
> ec_write functions to the ACPI EC driver. Calling these should allow the
> sonypi driver to avoid EC contention when ACPI is present.

Great. I've tested it and it works great here (I've modified sonypi
to use ec_read/write instead of the homebrew replacements). Feel free
to push the patch to Linus and I'll submit my modifications after that
(I have a quite large update pending for the sonypi driver, so I'll
submit all this probably this weekend).

> Unfortunately I don't think sonypi will be able to remove its own EC read
> and write functions, for the non-ACPI case.

I have no problem with that.

> Comments?

Well, not directly related to the EC thing but rather to the ACPI/sonypi
integration, but maybe you noticed that the sonypi driver also
re-implements some code which is originally defined in the ACPI bios
(SRS, DIS methods on "SPIC" ACPI object).

One day I should really call some ACPI exported function to do this,
but last time I looked at this (3 months ago ?), the ACPI API (the one
exported to external users) was still changing each day.

Have things improved in this area ?

Stelian.

-- 
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/