Hi,
Chris Wilson found and fixed a few bugs in the failure paths of the
scx200_wdt driver that I'm the maintainer for. Could you please apply
this patch that fixes these.
/Christer
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=scx200_wdt.patch
--- linux-2.5.47/drivers/char/scx200_wdt.c Mon Nov 11 03:28:26 2002
+++ linux-2.5.47-chris/drivers/char/scx200_wdt.c Sun Nov 17 19:27:32 2002
@@ -240,23 +240,28 @@
}
scx200_wdt_update_margin();
scx200_wdt_disable();
sema_init(&open_semaphore, 1);
r = misc_register(&scx200_wdt_miscdev);
- if (r)
+ if (r) {
+ release_region(SCx200_CB_BASE + SCx200_WDT_OFFSET,
+ SCx200_WDT_SIZE);
return r;
+ }
r = register_reboot_notifier(&scx200_wdt_notifier);
if (r) {
printk(KERN_ERR NAME ": unable to register reboot notifier");
misc_deregister(&scx200_wdt_miscdev);
+ release_region(SCx200_CB_BASE + SCx200_WDT_OFFSET,
+ SCx200_WDT_SIZE);
return r;
}
return 0;
}
static void __exit scx200_wdt_cleanup(void)
{
--=-=-=
-- "Just how much can I get away with and still go to heaven?"Freelance consultant specializing in device driver programming for Linux Christer Weinigel <christer@weinigel.se> http://www.weinigel.se
--=-=-=-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/