Re: [RFC] [PATCH] subarch cleanup

Christoph Hellwig (hch@infradead.org)
Fri, 22 Nov 2002 16:57:56 +0000


On Fri, Nov 22, 2002 at 10:40:55AM -0600, J.E.J. Bottomley wrote:
> > And every other header file is under the include path ... putting them
> > all mixed in with C files is just making a mess.
>
> No, look at e.g. SCSI. We have a scsi.h file in drivers/scsi which defines
> subsystem specific things that we only use within SCSI. We have
> include/scsi/scsi.h which defines things other subsystems can use.

Which is pretty stupid, btw. There are more than enough scsi HBA drivers
or emulation drivers outside drivers/scsi. I have a longstanding plan
to rationalize the scsi headers (the current state is really really messy),
and that includes moving everything but the truly midlayer-specific parts
like non-exported function to headers in include/scsi/.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/