Re: [PATCH] LSM changes for 2.5.50

[Greg KH]

On Thu, Dec 05, 2002 at 06:06:47PM +0000, Christoph Hellwig wrote:
> On Thu, Dec 05, 2002 at 10:03:58AM -0800, Greg KH wrote:
> > On Thu, Dec 05, 2002 at 05:00:02PM +0000, Christoph Hellwig wrote:
> > > On Thu, Dec 05, 2002 at 08:35:42AM -0800, Greg KH wrote:
> > > > ChangeSet 1.797.142.4, 2002/12/04 16:56:51-06:00, [e-mail]
> > > > 
> > > > LSM: add the example rootplug module
> > > 
> > > I don't think that's the kind of module that should be merged..
> > 
> > Why?  We have other "example" drivers in the kernel tree.  This is just
> > like that.
> 
> because it a) implements silly policy

That was the point :)
And I've seen sillier in "real" security products too...

> and b) violates layer rules.

What do you mean by this?  The fact that it abuses the USB core?  If so,
yes I agree with you, so I should probably move the "is this USB device
present" functionality into the USB core for everyone to use.  Would
that be better?

thanks,

greg k-h