Re: [TRIVIAL] Re: setrlimit incorrectly allows hard limits to exceed

Peter Chubb (peter@chubb.wattle.id.au)
Mon, 9 Dec 2002 13:47:10 +1100


>>>>> "Rik" == Rik van Riel <riel@conectiva.com.br> writes:

Rik> On Fri, 6 Dec 2002, Rusty Trivial Russell wrote:
>> > Just try "ulimit -H -m 10000" for memory limits that were not >
>> previously set. You end up with (hard limit = 10000) < (soft limit
>> = > unlimited).

>> + if (new_rlim.rlim_cur > new_rlim.rlim_max) + return -EINVAL;

Rik> Wouldn't it be better to simply take the soft limit down to
Rik> min(new_rlim.rlim_cur, new_rlim.rlim_max) ?

Single unix spec says to return EINVAL in this case.

[EINVAL]
An invalid resource was specified; or in a setrlimit() call, the new
rlim_cur exceeds the new rlim_max.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/