Re: [PATCH] aacraid 2.5

[Mark Haverkamp]

On Mon, 2002-12-09 at 14:02, Peter Chubb wrote:
> >>>>> "Mark" == Mark Haverkamp <[e-mail]> writes:
> 
> Mark> On Fri, 2002-12-06 at 16:30, Christoph Hellwig wrote:
> >> On Fri, Dec 06, 2002 at 07:45:42AM -0800, Mark Haverkamp wrote: >
> >> +/** > + * Convert capacity to cylinders > + * accounting for the
> >> fact capacity could be a 64 bit value > + * > + */ > +static inline
> >> u32 cap_to_cyls(sector_t capacity, u32 divisor) > +{ > +#ifdef
> >> CONFIG_LBD > + do_div(capacity, divisor); > +#else > + capacity /=
> >> divisor; > +#endif > + return (u32) capacity; > +}
> >> 
> >> Please use sector_div() instead.  It exists for a reason.
> 
> 
> Mark> Thanks for finding this.  I have enclosed a change using your
> Mark> suggestion.
> 
> 
> sector_div(a, b) is just like do_div(a, b) -- it returns the
> remainder, and sets a to a/b which is not reflected in your patch...
> 

oops, I didn't look closely enough at the sector_div code.
-- 
Mark Haverkamp <[e-mail]>